Messages in this thread | | | From | Blaisorblade <> | Subject | Re: [PATCH 4/6] x86_64: fix L1_CACHE_SHIFT_MAX for Intel EM64T [for 2.6.14?] | Date | Wed, 26 Oct 2005 00:44:25 +0200 |
| |
On Wednesday 26 October 2005 00:24, Andi Kleen wrote: > > No correctness issues, obviously. So this could even be merged for 2.6.14 > > (I'm not a fan of this idea, though). > > I don't think it's a good idea to mess with this for 2.6.14
> In general the maxaligned stuff is imho bogus and should be removed. That > is what CONFIG_X86_GENERIC is for. It doesn't make sense imho to separate > the variables in two aligned classes - either they should be aligned in all > cases or they shouldn't.
For what I see, that's based on the tradeoff between space and contention - for instance there are few zones only, so there's no big waste. In practice, interpreting !X86_GENERIC as "I will run this kernel on _this_ processor" could also be done.
However, in case you didn't note, max_align is never enough on EM64T currently, right? -- Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!". Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894) http://www.user-mode-linux.org/~blaisorblade
___________________________________ Yahoo! Mail: gratis 1GB per i messaggi e allegati da 10MB http://mail.yahoo.it
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |