Messages in this thread |  | | | Date | Mon, 24 Oct 2005 07:47:38 -0700 | | From | Paul Jackson <> | | Subject | Re: [PATCH 02/02] cpuset automatic numa mempolicy rebinding |
| |
Dave wrote: > Just think how that looks to a reviewer without the full context :)
I was just copying Andi's coding style for these cases, with this BUG() if no policy matched. When in Rome, do as the Romans.
> Perhaps the MBOL_BIND case needs a little helper function.
Eh ... that entire routine still fits on a page of my screen. I'm not sure that adding a helper function would clarify the code any.
Thanks for looking at it. If you're pretty sure I should change one of the above, squeek a little louder.
-- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson <pj@sgi.com> 1.925.600.0401 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |