Messages in this thread | | | Date | Fri, 21 Oct 2005 21:14:12 -0600 (MDT) | Subject | Re: [ACPI] Re: [Pcihpd-discuss] RE: [patch 2/2] acpi: add ability to derive irq when doing a surpriseremoval of an adapter | From | "Bjorn Helgaas" <> |
| |
> pci_read_config_byte(dev, PCI_INTERRUPT_PIN, &pin); > + > + /* > + * If a device has been "surprise" removed via > + * hotplug, the pin value will be invalid > + * In this case, we should use the stored > + * pin value from the pci_dev structure > + */ > + if (pin == 0xff) > + pin = dev->pin;
I think you should just always use dev->pin, and don't even bother trying the pci_read_config_byte(). Fewer code paths to worry about that way.
Bjorn
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |