lkml.org 
[lkml]   [2005]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [ACPI] Re: [Pcihpd-discuss] RE: [patch 2/2] acpi: add ability to derive irq when doing a surpriseremoval of an adapter
From
>  	pci_read_config_byte(dev, PCI_INTERRUPT_PIN, &pin);
> +
> + /*
> + * If a device has been "surprise" removed via
> + * hotplug, the pin value will be invalid
> + * In this case, we should use the stored
> + * pin value from the pci_dev structure
> + */
> + if (pin == 0xff)
> + pin = dev->pin;

I think you should just always use dev->pin, and don't even
bother trying the pci_read_config_byte(). Fewer code paths
to worry about that way.

Bjorn

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-10-22 05:16    [W:0.048 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site