lkml.org 
[lkml]   [2005]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 1/4] Swap migration V3: LRU operations
    Dave Hansen writes:

    [...]

    >
    > It makes much more sense to have something like:
    >
    > if (ret == ISOLATION_IMPOSSIBLE) {
    > list_del(&page->lru);
    > list_add(&page->lru, src);
    > }
    >
    > than
    >
    > + if (rc == -1) { /* Not possible to isolate */
    > + list_del(&page->lru);
    > + list_add(&page->lru, src);
    > + } if

    And
    if (ret == ISOLATION_IMPOSSIBLE)
    list_move(&page->lru, src);

    is even better.

    Nikita.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-10-21 17:52    [W:6.343 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site