lkml.org 
[lkml]   [2005]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] added sysdev attribute to sysdev show/store methods - for linux-2.6.13.4
    On Thu, Oct 20, 2005 at 05:42:50PM -0700, Jonathan Mayer wrote:
    > > It is a good idea, if someone needs access to that attribute
    > > information. But for now, no one does. When they do, I'll be glad to
    > > accept the patch.
    >
    > Hi Greg,
    >
    > My only concern, then, is that by the time somebody needs this patch,
    > the set of sysdev objects will have grown, requiring a big patch
    > instead of a small one.

    So? That's not a big deal, split it into more pieces. That's what was
    done when people did the same for the device attributes.

    > I would also argue that even existing sysdev objects could be
    > rewritten and cleaned up slightly (remove proliferation of methods) by
    > using the attribute.

    Now that would be a justification for accepting the patch, and is why I
    took it for the device attributes.

    > If you like, I could try doing that and submit it as part of this patch...

    That would be fine.

    thanks,

    greg k-h
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-10-21 06:14    [W:0.021 / U:1.248 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site