[lkml]   [2005]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [RFC: 2.6 patch] net/sunrpc/: possible cleanups
On Sat, Oct 01, 2005 at 08:40:19PM +0400, Alexey Dobriyan wrote:
> On Sat, Oct 01, 2005 at 04:20:41PM +0200, Adrian Bunk wrote:
> > -/* Just increments the mechanism's reference count and returns its input: */
> > -struct gss_api_mech * gss_mech_get(struct gss_api_mech *);
> > -
> > -struct gss_api_mech *
> > +static struct gss_api_mech *
> > gss_mech_get(struct gss_api_mech *gm)
> Comment is lost.

The comment made sense for the prototype at the header, but the function
now has only one caller in the file where it's defined.

If someone needs a comment to figure out what a function whose complete
contents is

static struct gss_api_mech *
gss_mech_get(struct gss_api_mech *gm)
return gm;

does, the problem is not a missing comment.



"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2005-10-02 16:43    [W:0.025 / U:19.416 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site