lkml.org 
[lkml]   [2005]   [Oct]   [18]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateTue, 18 Oct 2005 15:23:18 +0900 (JST)
SubjectRe: [PATCH] X25: Add ITU-T facilites
FromYOSHIFUJI Hideaki / 吉藤英明 <>
In article <1129615767.3695.15.camel@localhost.localdomain> (at Tue, 18 Oct 2005 16:09:27 +1000), Andrew Hendry <ahendry@tusc.com.au> says:

> +/* > +*     ITU DTE facilities> +*     Only the called and calling address> +*     extension are currently implemented.> +*     The rest are in place to avoid the struct> +*     changing size if someone needs them later> ++ */> +struct x25_dte_facilities {> +	unsigned int    calling_len, called_len;> +	char            calling_ae[20];> +	char            called_ae[20];> +	unsigned char   min_throughput;> +	unsigned short  delay_cumul;> +	unsigned short  delay_target;> +	unsigned short  delay_max;> +	unsigned char   expedited;> +};

Why don't you use fixed size members?
And we can eliminate 8bit hole.

struct x25_dte_facilities {
     u32             calling_len
     u32             called_len;
     u8              calling_ae[20];
     u8              called_ae[20];
     u8              min_throughput;
     u8              expedited;
     u16             delay_cumul;
     u16             delay_target;
     u16             delay_max;
};
--yoshfuji
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-10-18 08:26    [from the cache]
©2003-2008