Messages in this thread | | | Date | Mon, 17 Oct 2005 02:42:19 -0700 | From | Andrew Morton <> | Subject | Re: ohci1394 unhandled interrupts bug in 2.6.14-rc2 |
| |
Stefan Richter <stefanr@s5r6.in-berlin.de> wrote: > > Andrew Morton wrote: > > Jesse Barnes <jbarnes@virtuousgeek.org> wrote: > > > >>diff -X linux-2.6.14-rc2/Documentation/dontdiff -Naur linux-2.6.14-rc2.orig/drivers/ieee1394/ohci1394.c linux-2.6.14-rc2/drivers/ieee1394/ohci1394.c > >>--- linux-2.6.14-rc2.orig/drivers/ieee1394/ohci1394.c 2005-09-19 20:00:41.000000000 -0700 > >>+++ linux-2.6.14-rc2/drivers/ieee1394/ohci1394.c 2005-10-15 12:55:08.000000000 -0700 > [...] > >>+module_param(toshiba, bool, 0); > >>+MODULE_PARM_DESC(toshiba, "Toshiba Legacy-Free BIOS workaround (default=0)."); > [...] > > It would be really really preferable if we could find some automatic way of > > doing this. > > I agree. > > > Is it possible to use DMI matching, like > > arch/i386/kernel/acpi/sleep.c:acpisleep_dmi_table ? > > Earlier forms of the patch do DMI matching: > http://marc.theaimsgroup.com/?l=linux1394-devel&m=110790513206094 > http://www.janerob.com/rob/ts5100/tosh-1394.patch > [short-circuited by if (1) at the second URL]
Rob, can you finish that patch off and send it?
> Of course we don't have a complete picture of which models are affected > though.
I suppose we could do both. As people are found who need the module parameter, we grab their DMI strings and add them to the table?
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |