Messages in this thread | | | From | "Chen, Kenneth W" <> | Subject | RE: [PATCH 1/1] indirect function calls elimination in IO scheduler | Date | Mon, 17 Oct 2005 12:25:01 -0700 |
| |
Jens Axboe wrote on Monday, October 17, 2005 10:59 AM > you cannot ref count a statically embedded structure. It has to be > dynamically allocated.
I'm confused. For every block device queue, there is one unique elevator_t structure allocated via kmalloc. And vice versa, one elevator_t has only one request_queue points to it. This elevator_t structure is per q since it has pointer to per-queue elevator private data.
Since it is always one to one relationship, ref count is predictable and static. I see there are ref count on q->elevator, But it is always 2: one from object instantiation and one from adding an sysfs hierarchy directory. In this case, I don't see the difference. Am I missing something?
- Ken
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |