[lkml]   [2005]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] libata: fix broken Kconfig setup

    On Mon, 17 Oct 2005, Linus Torvalds wrote:
    > > And then with the quirk issue out of
    > > the way, CONFIG_SCSI_SATA becomes purely a boolean enable/disable-this-menu
    > > switch.
    > No it does not. You continue to ignore the fact that it's not an
    > enable/disable thing. It's a "can we enable SATA drivers" vs "can we
    > enable SATA drivers as modules" vs "do we do any SATA drivers at all?"
    > thing.
    > A tristate.

    Btw, if you want to have the _question_ always be y/n only, that's easy
    enough to do, just make that one do

    config SATA_MENU
    bool "Want to see SATA drivers"
    depends on SCSI != n

    config SCSI_SATA
    depends on SCSI && SATA_MENU
    default y

    and now you have a totally sensible setup, where the low-level drivers can
    depend on something sane.

    I don't think it _buys_ you anything, but hey, at least it's logical.

    Btw, wouldn't it be much nicer to also have this all in a totally separate
    Kconfig file? That SCSI Kconfig file is one of the biggest ones (yeah,
    drivers/net/Kconfig is bigger, but hey, that's not a surprise, is it ;)

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2009-11-18 23:46    [W:0.020 / U:3.504 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site