lkml.org 
[lkml]   [2005]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: x86_64: 2.6.14-rc4 swiotlb broken
On Mon, Oct 17, 2005 at 08:27:40AM -0700, Linus Torvalds wrote:
>
>
> On Mon, 17 Oct 2005, Andi Kleen wrote:
> >
> > The patch is actually not quite correct - in theory node 0 could be too small
> > to contain the full swiotlb bounce buffers.
>
> Is node 0 guaranteed to be all low-memory? What if it allocates stuff at
> the end of memory on NODE(0)?
>
> Anyway, it sounds like "alloc_bootmem_low_pages()" is seriously buggered
> if it allocates non-low pages, if only because of its name...
>
> > The real fix would be to get rid of the pgdata lists and just walk the
> > node_online_map on bootmem.c. The memory hotplug guys have
> > a patch pending for this.
>
> Argh. Which one should I pick? The NODE(0) one looks simpler, but is it
> sufficient for now in practice (with the real one going into 2.6.14+)?

That's the reason I made a small patch. It does work on the boxes we use.
But I like Yasunori-san's patch. Mine is just a chewing gum fix.

Thanks,
Kiran
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-10-17 17:39    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site