lkml.org 
[lkml]   [2005]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: PATCH: EDAC, core EDAC support code
From
Date
> +
> +static ctl_table mc_table[] = {
> + {-1, "panic_on_ue", &panic_on_ue,
> + sizeof(int), 0644, NULL, proc_dointvec},
> + {-2, "log_ue", &log_ue,
> + sizeof(int), 0644, NULL, proc_dointvec},
> + {-3, "log_ce", &log_ce,
> + sizeof(int), 0644, NULL, proc_dointvec},
> + {-4, "poll_msec", &poll_msec,
> + sizeof(int), 0644, NULL, proc_dointvec},
> + {-7, "panic_on_pci_parity", &panic_on_pci_parity,
> + sizeof(int), 0644, NULL, proc_dointvec},
> + {-8, "check_pci_parity", &check_pci_parity,
> + sizeof(int), 0644, NULL, proc_dointvec},
> +#ifdef CONFIG_EDAC_DEBUG
> + {-9, "debug_level", &edac_debug_level,
> + sizeof(int), 0644, NULL, proc_dointvec},
> +#endif
> + {0}
> +};

why aren't these module parameters? Nowadays you can have sysfs-runtime
changable module parameters... sounds a lot nicer than adding a chunk of
sysctl stuff

> +
> +#ifdef CONFIG_PROC_FS
> +static const char *mem_types[] = {
> + [MEM_EMPTY] = "Empty",
> + [MEM_RESERVED] = "Reserved",
> + [MEM_UNKNOWN] = "Unknown",
> + [MEM_FPM] = "FPM",
> + [MEM_EDO] = "EDO",
> + [MEM_BEDO] = "BEDO",
> + [MEM_SDR] = "Unbuffered-SDR",
> + [MEM_RDR] = "Registered-SDR",
> + [MEM_DDR] = "Unbuffered-DDR",
> + [MEM_RDDR] = "Registered-DDR",
> + [MEM_RMBS] = "RMBS"
> +};


why proc? Again this sounds like a platform sysfs thing...



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-10-16 10:28    [W:0.040 / U:1.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site