lkml.org 
[lkml]   [2005]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: uinput crash and fix
    On Sat, Oct 15, 2005 at 11:29:12PM +0200, emard@softhome.net wrote:
    > HI
    [...]
    > req = uinput_request_find(udev, ff_up.request_id);
    > - if (!(req && req->code == UI_FF_UPLOAD && req->u.effect)) {
    > + if (!req) {

    out of curiosity, instead of adding a whole if block wouldn't be easier
    to just write

    if (!req || !(req->code == UI_FF_UPLOAD && req->u.effect)) {

    in order to evaulate !req first and eventually dereference it?
    --
    mattia
    :wq!
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-10-16 00:03    [W:0.021 / U:126.504 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site