Messages in this thread | | | From | Herbert Xu <> | Subject | Re: [RFC][PATCH] rcu in drivers/net/hamradio | Date | Fri, 14 Oct 2005 23:37:01 +1000 |
| |
Suzanne Wood <suzannew@cs.pdx.edu> wrote: > > (1) bpq_new_device() calls list_add_rcu() labeled as > "list protected by RTNL." The comment may need to go > since the only apparent rtnl_lock()/unlock() pair encloses > the call to bpq_free_device() in bpq_cleanup_driver() > called upon module_exit().
The RTNL comment is correct actually.
bpq_new_device can only be called from bpq_device_event which is called from a netdev event handler. All netdev event handlers must be called uner the RTNL.
Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |