![]() | ||||||||||
Messages in this thread |
On Wed, 12 Oct 2005, Dave Hansen wrote: > On Tue, 2005-10-11 at 16:13 +0100, Mel Gorman wrote: > > +#ifdef CONFIG_ALLOCSTAT > > + memset((unsigned long *)zone->fallback_count, 0, > > + sizeof(zone->fallback_count)); > > + memset((unsigned long *)zone->alloc_count, 0, > > + sizeof(zone->alloc_count)); > > + memset((unsigned long *)zone->alloc_count, 0, > > + sizeof(zone->alloc_count)); > > + zone->kernnorclm_partial_steal=0; > > + zone->kernnorclm_full_steal=0; > > + zone->reserve_count[RCLM_NORCLM] = > > + realsize >> (MAX_ORDER-1); > > +#endif > > The struct zone is part of the pgdat which is zeroed at boot-time on all > architectures and configuration that I have ever audited. Re-zeroing > parts of it here is unnecessary. > > BTW, that '=0' with no spaces is anti-CodingStyle. > Blast, true. However, the whole block of code can be simply removed which I prefer. I didn't like the #ifdef in the middle of the function. -- Mel Gorman Part-time Phd Student Java Applications Developer University of Limerick IBM Dublin Software Lab - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | |||||||||
| Last update: 2005-10-12 12:22 [from the cache] ©2003-2008 | ||||||||||