Messages in this thread | | | Date | Wed, 12 Oct 2005 15:49:19 -0700 | From | Greg KH <> | Subject | Re: Fwd: Telecom Clock Driver for MPCBL0010 ATCA computer blade |
| |
On Wed, Oct 12, 2005 at 03:30:00PM -0700, Mark Gross wrote: > > Most significantly I moved the driver from a misc_device to a > platform_device.
You should still use the misc_device to register your file ops, just stick with the platform device for the sysfs stuff. You need that misc_device in order to work properly with udev. Have you tested this code on a udev-only system?
Other than that, it looks very good.
Oh, one minor thing:
> +#include <linux/sysfs.h> > +#define DEBUG > +#include <linux/device.h>
Do you always want DEBUG to be enabled? :)
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |