lkml.org 
[lkml]   [2005]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [linux-usb-devel] Re: [BUG/PATCH/RFC] Oops while completing async USB via usbdevio
On Mon, Oct 10, 2005 at 04:03:13PM -0400, Alan Stern wrote:
> On Mon, 10 Oct 2005, Harald Welte wrote:
>
> > + if ((!info || ((unsigned long)info != 1 &&
> > + (unsigned long)info != 2 && SI_FROMUSER(info)))
> > + && (euid ^ p->suid) && (euid ^ p->uid)
> > + && (uid ^ p->suid) && (uid ^ p->uid)) {
>
> No doubt this was copied from somewhere else. But why do people go to the
> effort of confusing readers by using "^" instead of "!="? These aren't
> bit-oriented values.

Well, I'd rather keep the new code as close as possible to the original
check_permission() code, to make it obvious that it's basically doing
the same thing. I think if you want to clean this up, it could be an
additional patch on top of mine (once there is a final version and it
gets merged.

> Alan Stern

--
- Harald Welte <laforge@gnumonks.org> http://gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2005-10-11 15:50    [W:0.101 / U:7.544 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site