Messages in this thread | | | Subject | Re: [PATCH 1/1] 2.6.14-rc3 x86: COMMAND_LINE_SIZE | From | Andi Kleen <> | Date | 11 Oct 2005 21:21:34 +0200 |
| |
Alon Bar-Lev <alon.barlev@gmail.com> writes: > > +config COMMAND_LINE_MAX_SIZE > + int "Maximum kernel command-line size" > + default 512 > + help > + This option allows you to specify maximum kernel command-line > + for kernel to handle.
I think making that a config is a really bad idea. What happens when the user specifies a very large value. Or a very small one? There are subtle dependencies with the boot loader, so this is mostly a lie anyways. And it doesn't really safe enough memory to bother with a CONFIG.
Also the last time I tried to increase this all kind of systems with old bootloaders exploded (e.g. lilo on systems with large EDID information - search the archives). Have these issues been resolved now? If yes then I would suggest to just double the default. If not it cannot be changed anyways.
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |