Messages in this thread | | | Date | Mon, 10 Oct 2005 15:32:56 +0200 | From | Alon Bar-Lev <> | Subject | Re: [PATCH] Re: THE LINUX/I386 BOOT PROTOCOL - Breaking the 256 limit |
| |
Hello,
1. Why don't you put this variable at config, and allow the user to specify the length during configuration? I have a patch that does just that.
2. THE MOST IMPORTANT task is to update the documentation at i386/boot.txt so that it will state that boot protocol 2.02+ field cmd_line_ptr should not be truncated and can be up to 4K bytes. Also fix "The kernel command line is null-terminated string up to 255 characters long,..." this is good for the old boot protocol, but not for the 2.02+ protocol.
Without this fix the bootloaders (Lilo, Grub) will not fix their code... So that users will still will not be able to use > 256 command line.
I've opened bug at Grub... and I wait for the documentation update so that they will modify their behaviour of truncating the cmd_line_ptr to 256.
Best Regards, Alon Bar-Lev.
On 10/10/05, Jesper Juhl <jesper.juhl@gmail.com> wrote: > On 10/10/05, Georg Lippold <georg.lippold@gmx.de> wrote: > > Hello Peter, > > > > my first post didn't get any attention, maybe it was too short. > > Here's a longer version: > > > > hpa@zytor.com wrote on Sept. 6th, 2005: > > > > [ wrt. COMMAND_LINE_SIZE=256 in linux/include/asm-i386/setup.h and > > linux/include/asm-i386/param.h ] > > > > >> I would like to push forward the idea to extend the command-line size... > > > [...] > > > Already pushed to Andrew. I will follow it up with a patch to extend > > > the command line, at least to 512. > > > > I would like to know the status of this. In linux-2.6.14-rc3 the > > COMMAND_LINE_SIZE is still 256 chars long. > > > > Here's a patch to fix that to 1024. > > > > What about the other archs ? > > include/asm/setup.h:#define COMMAND_LINE_SIZE 256 > include/asm/param.h:#define COMMAND_LINE_SIZE 256 > include/asm-m68knommu/setup.h:#define COMMAND_LINE_SIZE 512 > include/asm-powerpc/setup.h:#define COMMAND_LINE_SIZE 512 > include/asm-sh/setup.h:#define COMMAND_LINE_SIZE 256 > include/asm-um/setup.h:#define COMMAND_LINE_SIZE 4096 > include/asm-parisc/setup.h:#define COMMAND_LINE_SIZE 1024 > include/asm-x86_64/setup.h:#define COMMAND_LINE_SIZE 256 > include/asm-xtensa/setup.h:#define COMMAND_LINE_SIZE 256 > include/asm-alpha/setup.h:#define COMMAND_LINE_SIZE 256 > include/asm-arm26/setup.h:#define COMMAND_LINE_SIZE 1024 > include/asm-h8300/setup.h:#define COMMAND_LINE_SIZE 512 > include/asm-sparc/setup.h:#define COMMAND_LINE_SIZE 256 > include/asm-i386/setup.h:#define COMMAND_LINE_SIZE 256 > include/asm-i386/param.h:#define COMMAND_LINE_SIZE 256 > include/asm-cris/setup.h:#define COMMAND_LINE_SIZE 256 > include/asm-m32r/setup.h:#define COMMAND_LINE_SIZE (512) > include/asm-ia64/setup.h:#define COMMAND_LINE_SIZE 512 > include/asm-m68k/setup.h:#define COMMAND_LINE_SIZE CL_SIZE > include/asm-mips/setup.h:#define COMMAND_LINE_SIZE 256 > include/asm-mips/bootinfo.h:#define CL_SIZE > COMMAND_LINE_SIZE > include/asm-s390/setup.h:#define COMMAND_LINE_SIZE 896 > include/asm-v850/setup.h:#define COMMAND_LINE_SIZE 512 > include/asm-sh64/setup.h:#define COMMAND_LINE_SIZE 256 > include/asm-arm/setup.h:#define COMMAND_LINE_SIZE 1024 > include/asm-frv/param.h:#define COMMAND_LINE_SIZE 512 > include/asm-sparc64/setup.h:#define COMMAND_LINE_SIZE 256 > > Would it make sense to make it 1024 everywhere (and maybe move it out > of arch specific files and just set it in one central place) ? > > > -- > Jesper Juhl <jesper.juhl@gmail.com> > Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html > Plain text mails only, please http://www.expita.com/nomime.html > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |