Messages in this thread | | | Date | Mon, 10 Oct 2005 23:36:07 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH 01/16] GFS: headers |
| |
Hi!
> +#ifdef WANT_GFS2_CONVERSION_FUNCTIONS > + > +#define CPIN_08(s1, s2, member, count) {memcpy((s1->member), (s2->member), (count));} > +#define CPOUT_08(s1, s2, member, count) {memcpy((s2->member), (s1->member), (count));} > +#define CPIN_16(s1, s2, member) {(s1->member) = le16_to_cpu((s2->member));} > +#define CPOUT_16(s1, s2, member) {(s2->member) = cpu_to_le16((s1->member));} > +#define CPIN_32(s1, s2, member) {(s1->member) = le32_to_cpu((s2->member));} > +#define CPOUT_32(s1, s2, member) {(s2->member) = cpu_to_le32((s1->member));} > +#define CPIN_64(s1, s2, member) {(s1->member) = le64_to_cpu((s2->member));} > +#define CPOUT_64(s1, s2, member) {(s2->member) = cpu_to_le64((s1->member));} > + > +#define pv(struct, member, fmt) printk(" "#member" = "fmt"\n", struct->member); > +#define pa(struct, member, count) print_array(#member, struct->member, count);
Nice way to obfuscate code, I'd say. Can you just inline those macros? This is very hard to read... Pavel
-- if you have sharp zaurus hardware you don't need... you know my address - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |