lkml.org 
[lkml]   [2005]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH2 2/6] isicom: Type conversion and variables deletion
    From
    Date
    On Sul, 2005-10-09 at 21:42 +0200, Jiri Slaby wrote:
    > Type conversion and variables deletion
    >
    > Type which is needed to have accurate size was converted to [us]{8,16}.
    > Removed from void* cast.

    > static unsigned char *tmp_buf;
    > -static DECLARE_MUTEX(tmp_buf_sem);

    Unrelated change


    > - unsigned char isa;
    > + u16 base;
    > + u8 irq;
    > + u8 port_count;
    > + u16 status;
    > + u16 port_status; /* each bit for each port */
    > + u16 shift_count;
    > + struct isi_port *ports;
    > + s8 count;
    > + u8 isa;

    These don't need to be changed and base should in fact be unsigned long
    for portability.

    > spinlock_t card_lock; /* Card wide lock 11/5/00 -sameer */
    > unsigned long flags;
    > };
    >
    > struct isi_port {
    > - unsigned short magic;
    > + u16 magic;

    Ditto


    > - port->xmit_buf = (unsigned char *) page;
    > + port->xmit_buf = (u8*) page;

    tty buffers are specifically unsigned char

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-10-10 19:01    [W:0.020 / U:0.488 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site