Messages in this thread Patch in this message | | | Date | Fri, 7 Jan 2005 13:34:00 -0800 | From | Nishanth Aravamudan <> | Subject | [UPDATE PATCH] ieee1394/sbp2: use ssleep() instead of schedule_timeout() |
| |
On Sat, Dec 25, 2004 at 01:48:46AM +0100, Domen Puncer wrote: > Hi. > > Santa brought another present :-) > > I'll start mailing new patches these days, and after external trees get > merged, I'll be bugging you with the old ones. > > > Patchset is at http://coderock.org/kj/2.6.10-kj/
<snip>
> all patches: > ------------
<snip>
> msleep-drivers_ieee1394_sbp2.patch
Please consider updating to the following patch:
Description: Use ssleep() instead of schedule_timeout() to guarantee the task delays as expected. The existing code should not really need to run in TASK_INTERRUPTIBLE, as there is no check for signals (or even an early return value whatsoever). ssleep() takes care of these issues.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
--- 2.6.10-v/drivers/ieee1394/sbp2.c 2004-12-24 13:34:00.000000000 -0800 +++ 2.6.10/drivers/ieee1394/sbp2.c 2005-01-05 14:23:05.000000000 -0800 @@ -902,8 +902,7 @@ alloc_fail: * connected to the sbp2 device being removed. That host would * have a certain amount of time to relogin before the sbp2 device * allows someone else to login instead. One second makes sense. */ - set_current_state(TASK_INTERRUPTIBLE); - schedule_timeout(HZ); + ssleep(1); /* * Login to the sbp-2 device - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |