lkml.org 
[lkml]   [2005]   [Jan]   [6]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateThu, 6 Jan 2005 10:47:59 +0000
FromChristoph Hellwig <>
SubjectRe: 2.6.10-mm2
> +rio-cli-conversion.patch
> +rio_linux-64-bit-workaround.patch

RIO is totally broken on all plattforms, and rio-cli-conversion.patch
makes it even more broken with things like:

-#define disable(oldspl) save_flags (oldspl) 
-#define restore(oldspl) restore_flags (oldspl) 
+#define disable(oldspl) local_irq_save(oldspl);
+#define restore(oldspl) local_irq_restore(oldspl) ;

or

+       if (PortP->gs.flags & ASYNC_CLOSING){ 
+               interruptible_sleep_on(&PortP->gs.close_wait);
+       }
please drop rio-cli-conversion.patch and mark the driver BROKEN to wait
a little before finally removing it unless it'll get a major rewrite.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:09    [from the cache]
©2003-2008