lkml.org 
[lkml]   [2005]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH][5/?] count writeback pages in nr_scanned
    On Wed, Jan 05, 2005 at 09:32:07PM -0800, Andrew Morton wrote:
    > > > The slight improvement you suggested of waiting on _any_ random
    > > > PG_writeback to go away (instead of one particular one as I did in 2.4)
    >
    > It's a HUGE improvement.

    I didn't want to question the improvement in wall clock time terms.

    > For the third time: "fixing" this involves delivering a wakeup to all zones
    > in the page's classzone in end_page_writeback(), and passing the zone* into
    > blk_congestion_wait(). Only deliver the wakeup on every Nth page to get a
    > bit of batching and to reduce CPU consumption. Then demonstrating that the
    > change actually improves something.

    Since I cannot reproduce oom kills with writeback, I sure can't
    demonstrate it on bare hardware with unmodified kernel.

    But I dislike code that works by luck, and sure I could demonstrate it
    if I bothered to write an artificial testcase on simulated hardware.
    This is the only reason I mentioned this bug in the first place, not
    because I'm reproducing it.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:09    [W:0.022 / U:30.916 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site