lkml.org 
[lkml]   [2005]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch] remove unnessesary casts from drivers/mtd/maps/nettel.c and kill two warnings
    On Wed, 5 Jan 2005, Greg Ungerer wrote:

    >
    > Sorry for the slow response, I have been out on vacation the
    > last couple of weeks :-)
    >
    I Hope you had a nice vacation. :)

    >
    > Jesper Juhl wrote:
    > > I took a look at the cause for these warnings in the 2.6.10 kernel,
    > >
    > > drivers/mtd/maps/nettel.c:361: warning: assignment makes pointer from
    > > integer without a cast
    > > drivers/mtd/maps/nettel.c:395: warning: assignment makes pointer from
    > > integer without a cast
    > >
    > > and as far as I can see the casts in there (to unsigned long and back to
    > > void*) are completely unnessesary ('virt' in 'struct map_info' is a void
    > > __iomem *), and getting rid of those casts buys us a warning free build.
    > >
    > > Are there any reasons not to apply the patch below?
    > > Unfortunately I don't have hardware to test this patch, so it has been
    > > compile tested only.
    >
    > Looks good to me. I have applied it to my working tree.
    > Do you want me to send it to Linus?
    >

    I'd appreciate that.

    --
    Jesper Juhl

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:09    [W:0.021 / U:2.844 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site