Messages in this thread Patch in this message | | | Date | Wed, 5 Jan 2005 16:40:43 +0200 | From | "Michael S. Tsirkin" <> | Subject | [PATCH] deprecate (un)register_ioctl32_conversion |
| |
Hello, Andrew, all!
Since in -mm1 we now have a race-free replacement (that being ioctl_compat), here is a patch to deprecate (un)register_ioctl32_conversion.
Signed-off-by: Michael S. Tsirkin <mst@mellanox.co.il>
diff -ruI -u linux-2.6.10/include/linux/ioctl32.h linux-2.6.10-ioctls/include/linux/ioctl32.h --- linux-2.6.10/include/linux/ioctl32.h 2004-12-24 23:33:49.000000000 +0200 +++ linux-2.6.10-ioctls/include/linux/ioctl32.h 2005-01-05 20:19:46.716664232 +0200 @@ -23,9 +23,12 @@ */ #ifdef CONFIG_COMPAT -extern int register_ioctl32_conversion(unsigned int cmd, + +/* The following two calls trigger an unfixable module unload race. */ +/* Deprecated in favor of ioctl_compat in struct file_operations. */ +extern int __deprecated register_ioctl32_conversion(unsigned int cmd, ioctl_trans_handler_t handler); -extern int unregister_ioctl32_conversion(unsigned int cmd); +extern int __deprecated unregister_ioctl32_conversion(unsigned int cmd); #else - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |