lkml.org 
[lkml]   [2005]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] AC97 plugin suspend/resume
Liam Girdwood wrote:
> This patch sets suspend and resume to NULL in the ad1980 plugin.
>
> Signed-off-by: Liam Girdwood <liam.girdwood@wolfsonmicro.com>
>
> Liam
>
>
> ------------------------------------------------------------------------
>
> --- a/sound/oss/ac97_plugin_ad1980.c 2004-12-24 21:33:48.000000000 +0000
> +++ b/sound/oss/ac97_plugin_ad1980.c 2005-01-04 14:15:40.000000000 +0000
> @@ -89,6 +89,8 @@
> .name = "AD1980 example",
> .probe = ad1980_probe,
> .remove = __devexit_p(ad1980_remove),
> + .suspend = NULL,
> + .resume = NULL,
> };
>
> /**

There is really no reason to add these fields if they are NULL. Zero
(or NULL for pointers) is the default for all unspecified fields, and it
is kernel convention to use this feature to reduce clutter.

--
Brian Gerst
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:09    [W:0.059 / U:0.304 seconds]
©2003-2014 Jasper Spaans. Advertise on this site