Messages in this thread | | | Date | Mon, 31 Jan 2005 16:46:37 -0800 | From | Greg KH <> | Subject | Re: [PATCH][I2C] Marvell mv64xxx i2c driver |
| |
On Mon, Jan 31, 2005 at 11:41:28AM -0700, Mark A. Greer wrote: > Greg KH wrote: > > >On Tue, Jan 25, 2005 at 06:26:45PM -0700, Mark A. Greer wrote: > > > > > >>+static inline void > >>+mv64xxx_i2c_fsm(struct mv64xxx_i2c_data *drv_data, u32 status) > >> > >> > > > >This is a much too big of a function to be "inline". Please change it. > >Same for your other inline functions, that's not really needed, right? > > > > > > > >>+{ > >>+ pr_debug("mv64xxx_i2c_fsm: ENTER--state: %d, status: 0x%x\n", > >>+ drv_data->state, status); > >> > >> > > > >Please use the dev_* calls instead. It gives you an accurate > >description of the specific device that emits the messages. Also use it > >for all of the printk() calls in the driver too. > > > >thanks, > > > >greg k-h > > > > Certainly. I already posted this [incremental] patch based on your > previous comments, > http://www.ussg.iu.edu/hypermail/linux/kernel/0501.3/0941.html. Is that > better?
How about a whole new patch that I could apply? That would be better :)
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |