Messages in this thread | | | Date | Mon, 31 Jan 2005 17:13:22 -0500 | From | Dmitry Torokhov <> | Subject | Re: [2.6 patch] drivers/char/sonypi.c: make 3 structs static |
| |
On Mon, 31 Jan 2005 22:49:05 +0100, Stelian Pop <stelian@popies.net> wrote: > > sonypi.h is a "local" header file used only by sonypi.c. > > I would like to keep those tables in sonypi.h rather than putting > all into sonypi.c (or we could as well remove sonypi.h and put all the > contents into the .c). >
Hi,
What is the point of having an .h file if it is not used by anyone? Judging by the fact that it completely protected by #ifdef __KERNEL__ there should be no userspace clients either.
I always thought that the only time .h is needed is when you define interface to your code. I'd fold it to sonpypi.c.
-- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |