Messages in this thread Patch in this message | | | From | Jesse Barnes <> | Subject | Re: 2.6.10-mm1 | Date | Mon, 3 Jan 2005 09:19:20 -0800 |
| |
On Monday, January 3, 2005 2:07 am, Christoph Hellwig wrote: > > add-page-becoming-writable-notification.patch > > Add page becoming writable notification > > David, this still has the bogus address_space operation in addition to > the vm_operation. page_mkwrite only fits into the vm_operations scheme, > so please remove the address_space op. Also the code will be smaller > and faster witout that indirection..
And apparently it's broken on NUMA. I couldn't find generic_file_get/set_policy in my tree, which builds with CONFIG_NUMA enabled.
Jesse diff -Napur -X /home/jbarnes/dontdiff linux-2.6.10-mm1.orig/mm/filemap.c linux-2.6.10-mm1/mm/filemap.c --- linux-2.6.10-mm1.orig/mm/filemap.c 2005-01-03 08:58:46.000000000 -0800 +++ linux-2.6.10-mm1/mm/filemap.c 2005-01-03 09:04:32.000000000 -0800 @@ -1542,10 +1542,6 @@ struct vm_operations_struct generic_file .nopage = filemap_nopage, .populate = filemap_populate, .page_mkwrite = filemap_page_mkwrite, -#ifdef CONFIG_NUMA - .set_policy = generic_file_set_policy, - .get_policy = generic_file_get_policy, -#endif }; /* This is used for a general mmap of a disk file */ | |