Messages in this thread | | | Date | Fri, 28 Jan 2005 19:04:08 +0100 | From | Jörn Engel <> | Subject | Re: [PATCH] OpenBSD Networking-related randomization port |
| |
On Fri, 28 January 2005 18:17:17 +0100, Lorenzo Hernández García-Hierro wrote: > > Attached you can find a split up patch ported from grSecurity [1], as > Linus commented that he wouldn't get a whole-sale patch, I was working > on it and also studying what features of grSecurity can be implemented > without a development or maintenance overhead, aka less-invasive > implementations.
I can see why Linus isn't too excited about this patch:
o Increased entropy pool sizes are independent. Should be a seperate patch. o Huge numbers of #ifdef's in the code are Plain Wrong(tm). o Replacing current randomization functions with new ones without lengthy explanation doesn't make me happy.
Also, if the patch was inline instead of an attachment, I could easily quote it while commenting.
Not sure whether there are useful things in the patch, but in the current form I wouldn't want to take it. And usually I'm less picky than Linus.
Jörn
-- Eighty percent of success is showing up. -- Woody Allen - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |