lkml.org 
[lkml]   [2005]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: kernel oops!


On Fri, 28 Jan 2005, ierdnah wrote:
>
> is this patch better? should i test this too?

You probably should. The patch you've tested is really ugly, and not a fix
at all - it's really just depending on the compiler generating a specific
code sequence that will hide the race. As such, it's a patch I would only
accept in the standard kernel as an absolute last resort.

In contrast, the second patch I tested may actually _fix_ the race.

The fact that the first patch makes the oops go away is a good thing,
though: it shows that your oops really was due to that small race window,
and as such it helps validate that it wasn't anything else.

Thanks,

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-11-18 23:46    [W:0.065 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site