lkml.org 
[lkml]   [2005]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: 2.6.11-rc2/ext3 quota allocation bug on error path ...
    From
    Date
    Hello,

    On Sat, 2005-01-22 at 16:50, Herbert Poetzl wrote:
    > --- ./fs/ext3/xattr.c.orig 2005-01-22 15:07:50 +0100
    > +++ ./fs/ext3/xattr.c 2005-01-22 16:45:09 +0100
    > @@ -773,7 +773,7 @@ inserted:
    > error = ext3_journal_get_write_access(handle,
    > new_bh);
    > if (error)
    > - goto cleanup;
    > + goto cleanup_dquot;
    > lock_buffer(new_bh);
    > BHDR(new_bh)->h_refcount = cpu_to_le32(1 +
    > le32_to_cpu(BHDR(new_bh)->h_refcount));
    > @@ -783,7 +783,7 @@ inserted:
    > error = ext3_journal_dirty_metadata(handle,
    > new_bh);
    > if (error)
    > - goto cleanup;
    > + goto cleanup_dquot;
    > }
    > mb_cache_entry_release(ce);
    > ce = NULL;
    > @@ -844,6 +844,10 @@ cleanup:
    >
    > return error;
    >
    > +cleanup_dquot:
    > + DQUOT_FREE_BLOCK(inode, 1);
    > + goto cleanup;
    > +
    > bad_block:
    > ext3_error(inode->i_sb, __FUNCTION__,
    > "inode %ld: bad block %d", inode->i_ino,

    looks good. Can this please be added?

    THanks,
    --
    Andreas Gruenbacher <agruen@suse.de>
    SUSE Labs, SUSE LINUX GMBH

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:09    [W:0.027 / U:30.692 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site