lkml.org 
[lkml]   [2005]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 2.6.11-rc2-mm1
Hi!

> Review of the superio subsystem sneaked in through bk-i2c.patch:
>
>
> diff -Nru a/drivers/superio/Kconfig b/drivers/superio/Kconfig
> --- /dev/null Wed Dec 31 16:00:00 196900
> +++ b/drivers/superio/Kconfig 2005-01-23 22:34:15 -08:00
> @@ -0,0 +1,56 @@
> +menu "SuperIO subsystem support"
> +
> +config SC_SUPERIO
> + tristate "SuperIO subsystem support"
> + depends on CONNECTOR
> + help
> + SuperIO subsystem support.
> +
> + This support is also available as a module. If so, the module
> + will be called superio.ko.
>
> This doesn't mention what "SuperIO" is at all. Also please skip the .ko
> postfix for the module name as the intree Kconfigs do. The boilerplate has
> changed to:
>
> To compile this driver as a module, choose M here: the
> module will be called <foo>.

Could we kill this boilerplate? Just explain modules in CONFIG_MODULE
or something like that. Or making module name mandatory parameter for
tristates, or something like that...

Pavel
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:09    [W:0.238 / U:9.624 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site