lkml.org 
[lkml]   [2005]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    Subject[PATCH 2.6] I2C: Kill i2c_client.id
    Hi Greg,

    As discussed earlier on the LKML [1], here comes a patch set killing the
    id member of the i2c_client structure. Let me recap my main reasons for
    doing so:

    1* A client is already uniquely identified by the combination of the
    number of the bus it sits on and the address it is located at on this
    bus.

    2* The i2c core doesn't make use of this struct member. Such an id, if
    needed, would thus be private data and as such would belong to the data
    member. In fact, none of the drivers using this field really needs it as
    far as I could see.

    Killing that useless struct member will let us save some memory and kill
    some useless code (not much, admittedly).

    I will send 5 different patches, to be applied in order, although
    nothing critical will happen if applied in a different order. In each
    patch, most chucks are themselves independent from each other, so if any
    is rejected or delayed for some reason, the rest can still be applied.

    (1/5) Stop using i2c_client.id in i2c/chips drivers (mostly hardware
    monitoring drivers).
    (2/5) Stop using i2c_client.id in media/video drivers.
    (3/5) Stop using i2c_client.id in misc drivers.
    (4/5) Deprecate i2c_client.id.
    (5/5) Documentation update.

    Thanks.

    [1] http://lkml.org/lkml/2004/12/27/132

    --
    Jean Delvare
    http://khali.linux-fr.org/
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:09    [W:0.019 / U:59.660 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site