Messages in this thread | | | Date | Fri, 14 Jan 2005 14:14:39 -0600 | From | Tom Zanussi <> | Subject | Re: [PATCH 4/4] relayfs for 2.6.10: headers |
| |
Greg KH wrote: > On Thu, Jan 13, 2005 at 10:04:36PM -0500, Karim Yaghmour wrote: > >>+/** >>+ * have_cmpxchg - does this architecture have a cmpxchg? >>+ * >>+ * Returns 1 if this architecture has a cmpxchg useable by >>+ * the lockless scheme, 0 otherwise. >>+ */ >>+static inline int >>+have_cmpxchg(void) >>+{ >>+#if defined(__HAVE_ARCH_CMPXCHG) >>+ return 1; >>+#else >>+ return 0; >>+#endif >>+} > > > Shouldn't this be a build time check, and not a runtime one? >
This was to avoid having an ifdef in the main body of the code. It's only used in channel setup, so I did'nt worrry about runtime checking.
Thanks,
Tom
> - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |