![]() | |||||||||||
Messages in this thread |
On Fri, Jan 07, 2005 at 06:29:45PM +0200, Paul Mundt wrote:
> On Fri, Jan 07, 2005 at 11:41:04AM +0200, Paul Mundt wrote:
> > > Also, why have a local list of devices and not just use the list the
> > > driver core provides for you?
> > >
> > Probably because I wasn't aware that the driver core provided one. Now that I
> > see the bus_for_each_xxx() stuff I'll drop the list and use that instead.
> >
> I dropped this entirely as the release() stuff did what I was looking for..
>
> > Thanks for looking at this, I'll post a cleaned up version shortly.
>
> Here it is against current BK.. let me know if you have any other issues.
>
> Signed-off-by: Paul Mundt <paul.mundt@nokia.com>
>
> drivers/Makefile | 1
> drivers/sh/Makefile | 6
> drivers/sh/superhyway/Makefile | 7 +
> drivers/sh/superhyway/superhyway-sysfs.c | 47 +++++++
> drivers/sh/superhyway/superhyway.c | 205 +++++++++++++++++++++++++++++++
No Kconfig file to enable this option?
> +static struct device superhyway_bus_device = {
> + .bus_id = "superhyway",
> +};
This device doesn't have a release function, as it's tied to the module.
Are you sure it's race free? :)
> +static int __init superhyway_init(void)
> +{
> + extern int superhyway_scan_bus(void);
This should go in a .h file somewhere.
> +EXPORT_SYMBOL(superhyway_bus_type);
> +EXPORT_SYMBOL(superhyway_add_device);
> +EXPORT_SYMBOL(superhyway_register_driver);
> +EXPORT_SYMBOL(superhyway_unregister_driver);
Did you forget a .h file with these function prototypes?
Other than that, looks a whole lot better, nice job.
greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
| ||||||||||
| Last update: 2005-03-22 14:09 [from the cache] ©2003-2008 | |||||||||||