Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: 2.6.10-mm2: swsusp regression [update] | Date | Wed, 12 Jan 2005 23:44:20 +0100 |
| |
On Wednesday, 12 of January 2005 22:01, Pavel Machek wrote: > Hi! > > > [-- snip --] > > > > > > The regression is caused by the timer driver. Obviously, turning > > > > > > timer_resume() in arch/x86_64/kernel/time.c into a NOOP makes it go > > > > > > away. > > [-- snip --] > > > > > > > > > > ..you might want to look at i386 time code, they have common > > > > > ancestor, and i386 one seems to work. > > > > Well, I've changed timer_resume() in arch/x86_64/kernel/time.c into the > > following function: > > Ugh, looking at arch/i386/kernel/time.c... "This could have never > worked". > > It does something like get_cmos_time() - get_cmos_time()*HZ. It looks > seriously wrong. > > > (for example - the second number is always negative and huge). Would it mean > > that get_cmos_time() needs fixing? > > get_cmos_time() looks okay, but timer){suspend,resume} looks > hopelessly broken.
Well, why don't we convert them to noops, then, at least temporarily?
RJW
-- - Would you tell me, please, which way I ought to go from here? - That depends a good deal on where you want to get to. -- Lewis Carroll "Alice's Adventures in Wonderland" - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |