![]() | |||||||||||||
Messages in this thread |
On Wed, Jan 12, 2005 at 10:57:06AM +0800, Li Shaohua wrote: > Hi, > struct device->platform_data is designed for ACPI, BIOS or other > platform specific data, but some drivers misused the field which makes > adding ACPI handle in device core impossible. Greg suggested me changing > the name of the filed and so it breaks all such drivers, and then fix > them. I'll try to fix some, but it would be great if the driver authors > could do it. No, the kernel has the "you break it, you fix it" rule. And as you want to use platform_data for something other than the drivers that are currently using it for, you need to fix everyone else up before I can accept such a change. And yes, one could argue that those drivers are "doing the wrong thing", but hey, they did it first, as no one else was using this field, and it solved a need for them. So you could successfully argue that they are the correct ones here :) thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2005-03-22 14:09 [from the cache] ©2003-2008 | |||||||||||||