Messages in this thread | | | Subject | Re: make flock_lock_file_wait static | From | Arjan van de Ven <> | Date | Tue, 11 Jan 2005 09:31:39 +0100 |
| |
On Mon, 2005-01-10 at 09:23 -0500, Trond Myklebust wrote: > må den 10.01.2005 Klokka 09:38 (+0100) skreiv Arjan van de Ven: > > > > > is "sooner or later" and "maybe someone else uses it" worth making > > > everyone elses kernel bigger by 500 bytes of code ? > > > > eh 60 not 500; sorry need coffee > > It's an API that provides *necessary* functionality for those > filesystems that wish to override the standard flock(). It was very > recently introduced by a third party, so we haven't had time to code up > an NFS flock yet.
where "recently" is last september.... bloating the kernel unused since then...
> Removing it now will just mean that we have to reintroduce it in a month > or so when NFS and the other filesystems start to catch up.
if NFS indeed is going to use this in a month then you're probably right, bloating all kernels for another few weeks (before 2.6.11 is out anyway) isn't a big deal. I'm looking forward to nfs using this in this timeframe...
If it is going to take a LOT longer though I still feel it's wrong to bloat *everyones* kernel with this stuff.
(you may think "it's only 100 bytes", well, there are 700+ other such functions, total that makes over at least 70Kb of unswappable, wasted memory if not more.)
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |