Messages in this thread | | | Subject | Re: [PATCH 2.6.10-mm2] Use the new preemption code [2/3] Resend | From | Thomas Gleixner <> | Date | Mon, 10 Jan 2005 11:12:57 +0100 |
| |
On Mon, 2005-01-10 at 10:46, Russell King wrote: > On Mon, Jan 10, 2005 at 02:18:35AM +0100, Thomas Gleixner wrote: > > On Mon, 2005-01-10 at 01:06 +0000, Russell King wrote: > > > On Mon, Jan 10, 2005 at 01:53:26AM +0100, Thomas Gleixner wrote: > > > > This patch adjusts the ARM entry code to use the fixed up > > > > preempt_schedule() handling in 2.6.10-mm2 > > > > > > Looks PPCish to me. > > > > Sorry I messed that up. Call me the idiot of today. > > > > This patch adjusts the ARM entry code to use the fixed up > > preempt_schedule() handling in 2.6.10-mm2 > > Are you sure ARM suffers from this race condition? It sets preempt count > before enabling IRQs and doesn't use preempt_schedule().
There is no race for arm, but using the preempt_schedule() interface is the approach which Ingo suggested for common usage, but his x86 implementation was racy, so I fixed this first before modifying arm to use the interface. Ingo pointed out that he will change it to preempt_schedule_irq, but I'm not religious about the name.
tglx
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |