lkml.org 
[lkml]   [2005]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] /driver/net/wan/sbs520
Adam Anthony <AAnthony@sbs.com> :
> Thank you for the heads up A&M. I have destroyed the evil [^M]'s, and
> updated the package.
> http://prdownloads.sourceforge.net/sbs520lnxdrv/sbs520patch.bz2?download

o OsMapPhysToVirt
-> should be ioremap/pci_iomap()

o OsUnMapVirt
-> iounmap, etc.

o OsAllocateNonPagedMemory/OsMemcpy/OsStall/OsSleep/OsZeroMem
-> useless wrappers.

o OsAllocateDeviceMemory
Yuck, virt_to_bus !
Please read:
- linux-2.6.x/Documentation/DMA-mapping.txt
- linux-2.6.x/Documentation/DMA-API.txt
drivers/net/*.c provides a lot of good examples for recent PCI
devices.

o OsReadPciConfiguration
Please see pci_resource_{start/len} and friends.

At this point, lnxosl.c will be removable and nobody will regret it.

--
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:09    [W:0.026 / U:2.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site