Messages in this thread | | | From | Stephen Hemminger <> | Subject | Re: [PATCH] /driver/net/wan/sbs520 | Date | Mon, 10 Jan 2005 12:11:46 -0800 |
| |
Like most vendor drivers, this looks ugly full of obfuscating typedef's and MixedCase. Please make it conform to linux style.
Also, all global's should be static where possible to avoid name space pollution. Replace volatile with wmb() and rmb() which is probably what you need anyway. Don't bury volatile inside typedef.s
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |