lkml.org 
[lkml]   [2005]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] /driver/net/wan/sbs520
Date
Like most vendor drivers, this looks ugly full of obfuscating typedef's
and MixedCase. Please make it conform to linux style.

Also, all global's should be static where possible to avoid name space pollution.
Replace volatile with wmb() and rmb() which is probably what you need anyway.
Don't bury volatile inside typedef.s


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:09    [W:0.176 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site