Messages in this thread | | | Date | Mon, 06 Sep 2004 12:34:37 +0400 | From | Kirill Korotaev <> | Subject | Re: [PATCH] removes unnessary print of space |
| |
>>This patch removes unnessary print of space in bust_spinlocks(). >> printk("") wakeups klogd as well, > > Until some smarty comes along and optimises printk() to skip empty strings. > > An explicit wake_up_klogd() thing might make sense, rather than relying > upon side-effects. yup, you are right. I was the easiest, but not the best. I'll make a patch with wakeup_klogd.
>>no need to print a space and make a mess. > Can't say that I've ever noticed that space. We did. Many times.
I've noticed another thing. There is a default bust_spinlocks() in lib/bust_spinlocks.c. 4 architectures including x86 have their own copies of it, which are exactly the same as the default one.
So do we really need lib/bust_spinlocks.c or we can move a signle copy of this function to kernel/printk.c?
Kirill
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |