lkml.org 
[lkml]   [2004]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] FAT: rewrite the cache for file allocation table lookup (2/4)
From
Date
Christoph Hellwig <hch@infradead.org> writes:

>> +#if 0
>> +#define debug_pr(fmt, args...) printk(fmt, ##args)
>> +#else
>> +#define debug_pr(fmt, args...)
>> +#endif
>
> We have a pr_debug() in <linux/kernel.h> that you could use.

I hated KERN_DEBUG. But, well, maybe pr_debug() was enough...

I'll replace it for now, and will delete it after public test in
Andrew's tree.

>> +static inline int fat_max_cache(struct inode *inode)
>> +{
>> + return FAT_MAX_CACHE;
>> +}
>
> Do you plan to have per-inode caches later? This seems rather useless
> otherwise.

This cache is already per-inode.

Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:05    [W:0.367 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site