Messages in this thread | | | Date | Sat, 4 Sep 2004 10:21:21 +0200 | From | Jens Axboe <> | Subject | Re: bug in md write barrier support? |
| |
On Sat, Sep 04 2004, Neil Brown wrote: > On Friday September 3, hch@lst.de wrote: > > md_flush_mddev just passes on the sector relative to the raid device, > > shouldn't it be translated somewhere? > > Yes. md_flush_mddev should simply be removed. > The functionality should be, and largely is, in the individual > personalities.
Yes, sorry I was a little lazy there even though I followed the plugging conversion :(
> Is there documentation somewhere on exactly what an issue_flush_fn > should do (is it allowed to sleep? what must happen before it is > allowed to return, what is the "error_sector" for, that sort of thing).
It is allowed to sleep, you should return when the flush is complete. error_sector is the failed location, which really should be a dev,sector tupple.
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |