Messages in this thread | | | Date | Sat, 4 Sep 2004 20:13:36 +0300 | From | Yuval Turgeman <> | Subject | Re: [PATCH] Menuconfig search changes - pt. 3 |
| |
On Sat, 4 Sep 2004 02:47:29 +0200 (CEST), Roman Zippel <zippel@linux-m68k.org> wrote:
> Please send a complete patch, it makes commenting on it easier.
Ok, will do.
> You shouldn't compute the pattern at every search. You are correct, I fixed it.
> menu->dep contains only temporary information. The real information is in > prop->visible.expr. Fixed that also...
> sym->dep doesn't contain user relevant information. Fixed.
> With this you print all selection with every menu entry. > You probably also want to print sym->rev_dep, which is used to calculate > the selections for this symbol. I wasn't really aware of rev_dep - very cool! Added a "Selected by" tag also.
> > > while (submenu) { > > menu[j++] = submenu; > > submenu = submenu->parent; > > } > > This loop should stop when you find root_menu. It does stop when it gets to rootmenu (rootmenu's parent is NULL).
> > > if (j > 0) { > > + if (!hit) > > + hit = true; > > + if (prop->text) > > + fprintf(fp, "%s (%s)\n", prop->text, > > + sym->name); > > else > > fprintf(fp, "%s\n", sym->name); > > This test isn't necessary, every prompt has a text. Left overs from the old menu search. Removed.
> > > + space = (char*)malloc(sizeof(char)*j); > > This isn't necessary, just use "%*c" like the other indentations. Ok - I keep learning new stuff.... :) - Done also.
I'll submit a final patch against mm3 soon. Thanks for the help!
-- Yuval Turgeman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |