Messages in this thread | | | Date | Sat, 4 Sep 2004 18:11:43 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH 2/3] copyfile: sendfile |
| |
On Sat, Sep 04, 2004 at 06:59:38PM +0200, Jörn Engel wrote: > Creates vfs_sendfile(), which can be called from other places within > the kernel. Such other places include copyfile() and cowlinks. > > In principle, this just removes code from do_sendfile() to > vfs_sendfile(). On top of that, it adds a check to out_inode, > identical to the one on in_inode. True, the check for out_inode was > never needed, maybe that tells you something about the check to > in_inode as well. ;)
Both checks aren't nessecary.
> +++ linux-2.6.9-rc1-mm3/include/linux/syscalls.h 2004-09-04 18:17:15.000000000 +0200 > @@ -285,6 +285,8 @@ > asmlinkage long sys_unlink(const char __user *pathname); > asmlinkage long sys_rename(const char __user *oldname, > const char __user *newname); > +asmlinkage long sys_copyfile(const char __user *from, const char __user *to, > + umode_t mode);
oesn't seem to belong into this patch.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |