Messages in this thread |  | | | Date | Thu, 30 Sep 2004 11:06:37 +0200 | | From | Vojtech Pavlik <> | | Subject | Re: [PATCH] Readd panic blinking in 2.6 |
| |
On Thu, Sep 30, 2004 at 10:42:24AM +0200, Andi Kleen wrote: > > > > Something like > > > > spin_lock_irqsave(&i8042_lock, flags); > > i8042_flush(); > > i8042_ctr &= ~I8042_CTR_KBDINT & ~I8042_CTR_AUXINT; > > i8042_command(&i8042_ctr, I8042_CMD_CTL_WCTR); > > i8042_wait_write(); > > i8042_write_data(0xed); > > i8042_wait_read(); > > i8042_flush(); > > i8042_wait_write(); > > i8042_write_data(led); > > i8042_wait_read(); > > i8042_flush(); > > spin_unlock_irqrestore(&i8042_lock, flags); > > > > would be safer and more correct. > > That all takes far too many locks.
Ouch, yes. Just ignore the locks then. As it is, it would deadlock immediately.
> The risk of deadlocking during > panic is too great. I think the delay is fine (worked great under 2.4), > just need to fix the IBF issue you mentioned.
-- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |