Messages in this thread | | | From | Bartlomiej Zolnierkiewicz <> | Subject | Re: PATCH: (Test) it8212 driver for 2.6.9rc3 | Date | Fri, 1 Oct 2004 00:01:27 +0200 |
| |
On Thursday 30 September 2004 23:35, Alan Cox wrote: > On Thu, Sep 30, 2004 at 10:45:18PM +0200, Bartlomiej Zolnierkiewicz wrote: > > - merge+describe needed IDE core changes > > Happily. I'm of the opinion the "ident whacking" callback isnt justified, > only one driver has a need for it and that driver can do it in the iops hook.
ok, you are right
> > - fix coding style and whitespace damage > > Yeah > > > - kill useless DECLARE_ITE_DEV macro > > I'd prefer to keep it (there are likely to be some related devices from > the databook)
you can add it when needed
> > - add __init to it8212_ide_init() > > Good point - will fix
thanks - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |